BUG: loc against CategoricalIndex may results in normal Index #11607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11586.
After the PR:
There are separate paths when
CategoricalIndexvalues (codes) are unique and not-unique and both fixed.Also,
.reindexintentionally returns normalIndexwhen passed values are notCategorical, I kept the behavior as it is. If.reindexcan always returnCategoricalIndex, above 2 separate fixes are not required (fixing.reindexto returnCategoricalIndexshould work both paths).